QtMir

Merge lp://staging/~dandrader/qtmir/improveKbdEventPrint into lp://staging/qtmir

improveKbdEventPrint
Merge into trunk

Proposed by Daniel d'Andrada on 2017-03-21

Status:	Approved
Approved by:	Gerry Boland on 2017-03-27
Approved revision:	620
Proposed branch:	lp://staging/~dandrader/qtmir/improveKbdEventPrint
Merge into:	lp://staging/qtmir
Diff against target:	59 lines (+38/-2) 1 file modified src/common/debughelpers.cpp (+38/-2)
To merge this branch:	bzr merge lp://staging/~dandrader/qtmir/improveKbdEventPrint
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Gerry Boland (community)		2017-03-21	Approve on 2017-03-27
Unity8 CI Bot (community)	continuous-integration		Approve on 2017-03-22
Review via email: mp+320564@code.staging.launchpad.net

Commit message

Make mirKeyboardEventToString() also print modifiers

Description of the change

* Are there any related MPs required for this MP to build/function as expected? Please list.
No

* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Not applicable

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2017-03-21:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-ci/605/rebuild

review: Approve (continuous-integration)

Revision history for this message

Gerry Boland (gerboland) wrote on 2017-03-22:

Is it useful to add "none"? The absence of a modifier could just as easily be represented by "[]"

Also, Mir has it's own debug printer for input events, could we use it more and save ourselves writing debug code.

review: Needs Information

Revision history for this message

Daniel d'Andrada (dandrader) wrote on 2017-03-22:

Oh, I pushed the unfinished version that only prints one or two values.
And now I lost the finished one. :/

On 22/03/2017 11:09, Gerry Boland wrote:
> Review: Needs Information
>
> Is it useful to add "none"? The absence of a modifier could just as easily be represented by "[]"

Sure

> Also, Mir has it's own debug printer for input events, could we use it more and save ourselves writing debug code.

You mean the mir reports that are enabled by env vars?

lp://staging/~dandrader/qtmir/improveKbdEventPrint updated on 2017-03-22

620. By Daniel d'Andrada on 2017-03-22: latest version

Revision history for this message

Unity8 CI Bot (unity8-ci-bot) wrote on 2017-03-22:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-ci/612/rebuild

review: Approve (continuous-integration)

Revision history for this message

Gerry Boland (gerboland) wrote on 2017-03-27:

> > Also, Mir has it's own debug printer for input events, could we use it more
> and save ourselves writing debug code.
>
>
> You mean the mir reports that are enabled by env vars?
Yeah. Do you want to keep runtime switchability?

Revision history for this message

Gerry Boland (gerboland) wrote on 2017-03-27:

lgtm

review: Approve

Unmerged revisions

620. By Daniel d'Andrada on 2017-03-22: latest version
619. By Daniel d'Andrada on 2017-03-21: Make mirKeyboardEventToString() also print modifiers

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes:

Daniel d'Andrada

Mir development team