Code review comment for lp://staging/~cyphermox/libappindicator/fix-tests

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

This looks good to me. However, looking at configure in the pbuilder, it seems there is one python extension build-dep missing:

checking for headers required to compile python extensions... not found
configure: error: could not find Python headers
dh_auto_configure: ../../configure --build=x86_64-linux-gnu --prefix=/usr --includedir=${prefix}/include --mandir=${prefix}/share/man --infodir=${prefix}/share/info --sysconfdir=/etc --localstatedir=/var --libdir=${prefix}/lib/x86_64-linux-gnu --libexecdir=${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode --disable-dependency-tracking --with-gtk=2 --enable-gtk-doc --disable-scrollkeeper --enable-introspection returned exit code 1
make[1]: *** [doconfiguregtk2-python2.7] Error 2
make[1]: Leaving directory `/tmp/buildd/libappindicator-12.10.1'
make: *** [build] Error 2

Once this is fixed, feel free to approve it :)

review: Needs Fixing

« Back to merge proposal