Ubuntu CI Engine

Code review comment for lp://staging/~cprov/uci-engine/1335753-glance-creds

  1. 1335753-glance-creds
  2. Merge into trunk
Revision history for this message
Andy Doan (doanac) wrote :

I mostly like it. I noticed a bug a though. I think any test failing because it assumes the location of the unit-config should be considered broken. I've got MP's on the way:

 https://code.launchpad.net/~doanac/uci-engine/lander-code-layout/+merge/225046

that are placing unit_config *outside* our code directory, so moving forward this assumption will definitely not work.

Reply

« Back to merge proposal