Code review comment for lp://staging/~cprov/uci-engine/1335753-glance-creds

Revision history for this message
Celso Providelo (cprov) wrote :

The fact that we have tests that depend on 'unit_config' on the project root is wrong, in fact. If it's not committed in the VCS it should be handled ad-hoc by a testing fixture.

Also, the only test that needs to exercise disk operations with 'unit_config' is the one I've added in this branch, all the rest of the system should mock get_auth_config() and use whatever result they expect.

« Back to merge proposal