Code review comment for lp://staging/~cprov/launchpad/bug-424797-buildd-manager-test-failure

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

reviewer jml

= Summary =

This branch fixes https://bugs.edge.launchpad.net/soyuz/+bug/424797

As reported in the bug, It was originally caused by a change in sampledata. However it is quite intriguing to see failures like that being 'swallowed' in our test suite.

It turns out that currently any failures/errors on trial.unittest.TestCase are ignored.

{{{
class TestTrial(TrialTestCase):

    def test_swallowed_errors(self):
        self.assertEquals(1, 2)
}}}

{{{
$ ./bin/test -vv -t TestTrial
Running tests at level 1
Running zope.testing.testrunner.layer.UnitTests tests:
  Set up zope.testing.testrunner.layer.UnitTests in 0.000 seconds.
  Running:
 test_swallowed_errors (lp.buildmaster.tests.test_manager.TestTrial)

Failure in test test_swallowed_errors (lp.buildmaster.tests.test_manager.TestTrial)

  Ran 1 tests with 0 failures and 0 errors in 0.009 seconds.
Tearing down left over layers:
  Tear down zope.testing.testrunner.layer.UnitTests in 0.000 seconds.
}}}

This is currently happening in buildbot, so I assume it's not a *karmic* issue.

Ideally I would like to have the specific test fixing (contained in the branch) and the trial-related fixes landed separately, but if it's simple enough I don't mind mixing both.

== Tests ==

/bin/test -vv -t testScanRescuesJobFromBrokenBuilder

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/buildmaster/tests/test_manager.py
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkqkA78ACgkQ7KBXuXyZSjAIPACeOwhX0/FCWxeYJAgrzf2kjlAq
qJUAmgMZAEz7WBsrX/n6q2uV9lotnm08
=G72k
-----END PGP SIGNATURE-----