Code review comment for lp://staging/~cprov/launchpad/bug-416789-distribution-ppas-icons

On Wed, Sep 2, 2009 at 7:42 AM, Gavin
Panella<email address hidden> wrote:
> Review: Approve code
> Line 107 has a small typo, s/arq/arch, but otherwise it looks good :)

This typo comes from the CSS sprites declaration, I wasn't aware that
my change was the only callsite.
Fixed both.

> BTW, I just tried using two-column-list in a portlet and it did not work properly; it rendered only one row on the same line, then the others were staggered. Have you seen that?

two-column-list only applies to multiples <dl>s, not multiple <dt>s
within the same <dl>:

{{{
<div class="two-columns">
  <dl><dt>C1</dt><dd>one</dd></dl>
  <dl><dt>C2</dt><dd>two</dd></dl>
  <dl><dt>C1</dt><dd>three</dd><dt>C1</dt><dd>three</dd></dl>
</div>
}}}
--
Celso Providelo <email address hidden>
IRC: cprov, Jabber: <email address hidden>, Skype: cprovidelo
1024D/681B6469 C858 2652 1A6E F6A6 037B B3F7 9FF2 583E 681B 6469