Code review comment for lp://staging/~cprov/launchpad/bug-416789-distribution-ppas-icons

Revision history for this message
Celso Providelo (cprov) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

= Summary =

This branch fixes https://bugs.edge.launchpad.net/bugs/416789 by adjusting the style bits (specially icons) lost during the 3.0 redesign.

It also benefits of IPPA/fmt:link and removes the need of pagetitles.py for that page.

== Tests ==

./bin/test -vv -t xx-ubuntu-ppas.txt

== Demo and Q/A ==

https://launchpad.dev/ubuntu/+ppas

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/soyuz/templates/distribution-portlet-ppa-architectures.pt
  lib/lp/soyuz/stories/ppa/xx-ubuntu-ppas.txt
  lib/canonical/launchpad/pagetitles.py
  lib/lp/soyuz/templates/distribution-ppa-list.pt
  lib/lp/registry/browser/distribution.py
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkqeB5EACgkQ7KBXuXyZSjB28wCgrcNAAF9ofH/XEZPcC8Cbz5XN
KwoAoKePThNUrCZC+aKVyVSZEgaq/GEK
=IjaM
-----END PGP SIGNATURE-----

« Back to merge proposal