Code review comment for lp://staging/~cprov/launchpad/bug-412715-registration-info-in-base-layout

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

= Summary =

This branch implements the easy-solution for https://bugs.edge.launchpad.net/launchpad-foundations/+bug/412715

It creates the 'registering' slot on the base-layout which can be used to present information styled (discreetly) at the right of the page label, e.g.:

'registered by Celso Providelo on 2009-01-01'

== Pre-implementation notes ==

I've followed Curtis suggestion and implemented the template slot, this way pages needing and in a position to fill it (almost all +index pages) will look nicer.

Ideally, this slot could be filled automatically for context providing IRegistration (basically 'registrant' and 'date_created'). However adapting our content classes will take longer than we can afford in 3.0. That's mainly why being able to fill the slot ad-hoc might be good enough for now.

== Tests ==

./bin/test -vv -t base-layout.txt

== Demo and Q/A ==

I've filled the 'registering' slot in some key pages, primarily for illustration how it works.

https://launchpad.dev/ubuntu
https://launchpad.dev/ubuntu/hoary
https://launchpad.dev/ubuntu/+source/mozilla-firefox/0.9/+build/8

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/templates/distroseries-details.pt
  lib/lp/registry/templates/distroseries-index.pt
  lib/lp/registry/templates/distribution-index.pt
  lib/lp/soyuz/templates/build-index.pt
  lib/lp/app/browser/tests/base-layout.txt
  lib/lp/app/templates/base-layout.pt
  lib/canonical/launchpad/icing/style-3-0.css
  lib/lp/app/browser/tests/testfiles/main-registering.pt
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkqw2yQACgkQ7KBXuXyZSjBWdgCgnoQtQMuSWOy25FmWbK8xbopu
JwkAn11+FirNwXKx/9NATnOClSlNuEGw
=83+m
-----END PGP SIGNATURE-----