Code review comment for lp://staging/~cprov/core-result-checker/lint
Revision history for this message
| Thomi Richards (thomir-deactivatedaccount) wrote | # |
review:
Needs Fixing
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
513534c
demo site
(Get the code!)
My vote is not to merge this. As shown in the diff, pylint doesn't understand some pretty straight-forward things, and forces us to either make our code less clear, or litter linter disabling comments everywhere.
If silly errors are landing in trunk, let's make sure we do a better job of reviewing MPs, writing tests, and/or manually testing our code (as appropriate to the situation).