britney

Merge lp://staging/~cprov/britney/boottest-double-blocking into lp://staging/~ubuntu-release/britney/britney2-ubuntu

  1. boottest-double-blocking
  2. Merge into britney2-ubuntu
Proposed by Celso Providelo
Status: Merged
Merged at revision: 432
Proposed branch: lp://staging/~cprov/britney/boottest-double-blocking
Merge into: lp://staging/~ubuntu-release/britney/britney2-ubuntu
Diff against target: 112 lines (+53/-8)
2 files modified
britney.py (+8/-6)
tests/test_boottest.py (+45/-2)
To merge this branch: bzr merge lp://staging/~cprov/britney/boottest-double-blocking
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Vincent Ladeuil (community) Approve
Ubuntu Release Team Pending
Review via email: mp+250444@code.staging.launchpad.net

Description of the change

Fixing BootTest criteria to stop doubling-blocking package promotion, as reported in:

https://trello.com/c/SxBZD8kN/37-1-boottest-get-a-review-for-britney-boottest-testing-criteria-shared-branch

If an source was already blocked by any previous criteria (autopkgtest) it does not need to be blocked again by BootTest (although boottest job and status will continue to be updated).

To post a comment you must log in.
lp://staging/~cprov/britney/boottest-double-blocking updated
432. By Celso Providelo

Test ADT & BootTest criteria running simultaneously. Fixed minor issue related to doubling-blocking promotions.

433. By Celso Providelo

Only enable BOOTTEST for testing, so britney.conf is safe on trunk.

Revision history for this message
Vincent Ladeuil (vila) wrote :

One more test with adt passing and autopkgtest running should be even closer to the issue we encounter in production iiuc.

Revision history for this message
Vincent Ladeuil (vila) wrote :

Bah, hit the button before voting.

I would be more comfortable with the added test but I think the existing one is already providing us with a way to reproduce issues in that area anyway.

review: Approve
Revision history for this message
Celso Providelo (cprov) wrote :

Vincent,

Thanks for the review. We can add more tests exercising the production environment (adt + boottest), perhaps operating only on the happy-path. However in order to reproduce the double-blocking error adt and boottest have to block the promotion in question.

Revision history for this message
Vincent Ladeuil (vila) wrote :

> However in order to reproduce the double-blocking error adt and boottest have
> to block the promotion in question.

OIC ! Thanks for the clarification I misunderstood the meaning of the tests indeed.

Revision history for this message
Colin Watson (cjwatson) wrote :

I think you should still add the boottest excuse; so move excuse.addreason("boottest") outside the excuse.is_valid test, but still within the status not in BootTest.VALID_STATUSES test.

review: Needs Fixing
lp://staging/~cprov/britney/boottest-double-blocking updated
434. By Celso Providelo

Add 'boottest' excuse failure reason when it has failed even if the previous tests had already failed.

Revision history for this message
Celso Providelo (cprov) wrote :

Colin,

It make sense, fix added in r434. Thanks.

Revision history for this message
Colin Watson (cjwatson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches