Merge lp://staging/~costales/unav/0.59-general-fixes into lp://staging/unav
Proposed by
costales
Status: | Merged | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Approved by: | Nekhelesh Ramananthan | ||||||||||||
Approved revision: | 86 | ||||||||||||
Merged at revision: | 53 | ||||||||||||
Proposed branch: | lp://staging/~costales/unav/0.59-general-fixes | ||||||||||||
Merge into: | lp://staging/unav | ||||||||||||
Prerequisite: | lp://staging/~nik90/unav/marcos-menu-structure | ||||||||||||
Diff against target: |
2295 lines (+460/-1572) 14 files modified
nav/img/header/center_onpos.svg (+0/-167) nav/img/header/center_onpos_light.svg (+0/-167) nav/img/header/destination.svg (+0/-255) nav/img/header/gps_off.svg (+0/-161) nav/img/header/nav-actions-transparent.svg (+195/-0) nav/img/header/nav-actions.svg (+195/-0) nav/img/header/transparent_center_onpos.svg (+0/-167) nav/img/header/transparent_center_onpos_light.svg (+0/-167) nav/img/header/transparent_destination.svg (+0/-255) nav/img/header/transparent_gps_off.svg (+0/-168) nav/index.html (+8/-1) nav/locales/unav.pot (+52/-54) qml/Main.qml (+8/-8) qml/js/PoiCategories.js (+2/-2) |
||||||||||||
To merge this branch: | bzr merge lp://staging/~costales/unav/0.59-general-fixes | ||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Nekhelesh Ramananthan | Approve | ||
Review via email: mp+292185@code.staging.launchpad.net |
This proposal supersedes a proposal from 2016-04-18.
To post a comment you must log in.
Icons are missing in the POI Page for those POI Category names that you changed. The POI category icon is defined as,
source: Qt.resolvedUrl( "../nav/ img/poi/ " + model.en_label + ".svg")
As you can see, it depends on the model.en_label
So to fix it, you will have to name the icons with the same en_label to ensure all icons are visible.
B&B.svg => Bed & Breakfast.svg
Convenience.svg => Convenience Store.svg
And so on ... .