Code review comment for lp://staging/~cjwatson/launchpad/configurable-germinate-base

Revision history for this message
William Grant (wgrant) wrote :

Overriding the config should usually only been done in high-level integration tests. What was the rationale behind having makeSeedStructures() look up the config option, rather than doing it in generateExtraOverrides() or even process()? That would surely make testing less ugly.

review: Needs Information

« Back to merge proposal