Code review comment for lp://staging/~cjohnston/ubuntu-ci-services-itself/1285302

Revision history for this message
Francis Ginther (fginther) wrote :

I've tested this with the losas charm and with the ci-train charm. Both fail unless the lts version is used. The problem is that both of these charms use the 'jenkins.model.JenkinsLocationConfiguration.xml' file to specify the IP address of the jenkins instance. This feature is not introduced until 1.494 [1], these charms are installing 1.424.6 when 'lts' is not used. When 'lts' is used, 1.532.2 jenkins is installed.

From my earlier jenkins charm experiments, I found that older versions of jenkins store the IP address in 'hudson.tasks.Mailer.xml'.

So, I see 2 options:
1) if we want to use these charms and the older jenkins version, we need to supply 'hudson.tasks.Mailer.xml' (maybe we can include this in the lander-jenkins charm).
2) package the 1.532.2 jenkins in our PPA.

I vote for 2 as long as it's not a dependency hell.

[1] http://javadoc.jenkins-ci.org/jenkins/model/JenkinsLocationConfiguration.html

review: Needs Fixing

« Back to merge proposal