Summit

Merge lp://staging/~cjohnston/summit/refresh-hangout-link into lp://staging/summit

refresh-hangout-link
Merge into trunk

Proposed by Chris Johnston on 2013-03-04

Status:	Work in progress
Proposed branch:	lp://staging/~cjohnston/summit/refresh-hangout-link
Merge into:	lp://staging/summit
Diff against target:	25 lines (+5/-0) 1 file modified summit/schedule/templates/schedule/virtual_meeting.html (+5/-0)
To merge this branch:	bzr merge lp://staging/~cjohnston/summit/refresh-hangout-link
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Michael Hall (community)		Needs Fixing on 2013-03-05
Adnane Belmadiaf	2013-03-04	Approve on 2013-03-04
Review via email: mp+151614@code.staging.launchpad.net

Commit message

Refresh hangout link when the broadcast url is added

Revision history for this message

Adnane Belmadiaf (daker) wrote on 2013-03-04:

+1 from me

review: Approve

Revision history for this message

Michael Hall (mhall119) wrote on 2013-03-05:

Doesn't work

review: Needs Fixing

Revision history for this message

Adnane Belmadiaf (daker) wrote on 2013-03-05:

i think it should be something like :
$('#hangout_url').html('<h3><a href="'+ meeting.hangout_url +'">Join the Hangout on Air</a></h3>');
since we need to get the link from json object not the python object

Revision history for this message

Michael Hall (mhall119) wrote on 2013-03-05:

Except you're not going to get meeting.hangout_url from the JSON API because we filter that out so that it isn't publicly available, and we can't filter based on an instance of the data being returned ATM