Merge lp://staging/~cjohnston/qa-dashboard/1206401 into lp://staging/qa-dashboard

Proposed by Chris Johnston
Status: Merged
Approved by: Chris Johnston
Approved revision: 533
Merged at revision: 529
Proposed branch: lp://staging/~cjohnston/qa-dashboard/1206401
Merge into: lp://staging/qa-dashboard
Diff against target: 417 lines (+272/-23)
9 files modified
smokeng/migrations/0004_add_stdout_stderr.py (+127/-0)
smokeng/models.py (+2/-0)
smokeng/tables.py (+8/-5)
smokeng/templates/smokeng/test_result_detail.html (+49/-0)
smokeng/templates/smokeng/test_results_popup.html (+0/-10)
smokeng/tests.py (+13/-0)
smokeng/urls.py (+8/-3)
smokeng/utah_utils.py (+6/-0)
smokeng/views.py (+59/-5)
To merge this branch: bzr merge lp://staging/~cjohnston/qa-dashboard/1206401
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Joe Talbott Approve
Chris Johnston Needs Resubmitting
Review via email: mp+177693@code.staging.launchpad.net

Commit message

Add stderr and stdout to dashboard test case page

To post a comment you must log in.
Revision history for this message
Andy Doan (doanac) wrote :

242 +def test_result_detail(request, release, image_id, name, id):
243 + image = get_object_or_404(SmokeImage, id=image_id)
244 + result = get_object_or_404(
245 + SmokeResult,
246 + image__id=image_id,
247 + name=name,
248 + publish=True,
249 + )
250 + tests = SmokeTestResult.objects.filter(
251 + result=result,
252 + pk=id,
253 + )

I think you can replace lines 243-253 with:

 test = SmokeTestResult.objects.get(pk=id)

532. By Chris Johnston

Fixes

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:532
http://s-jenkins:8080/job/dashboard-ci/121/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins:8080/job/dashboard-ci/121/rebuild

review: Needs Fixing (continuous-integration)
533. By Chris Johnston

Changes per Andy's request

Revision history for this message
Chris Johnston (cjohnston) :
review: Needs Resubmitting
Revision history for this message
Joe Talbott (joetalbott) wrote :

LGTM

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:533
http://s-jenkins:8080/job/dashboard-ci/122/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins:8080/job/dashboard-ci/122/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches