Merge lp://staging/~cimi/overlay-scrollbar/align-thumb-position into lp://staging/overlay-scrollbar
Proposed by
Andrea Cimitan
Status: | Merged |
---|---|
Approved by: | Andrea Cimitan |
Approved revision: | 330 |
Merged at revision: | 313 |
Proposed branch: | lp://staging/~cimi/overlay-scrollbar/align-thumb-position |
Merge into: | lp://staging/overlay-scrollbar |
Diff against target: |
119 lines (+99/-6) 1 file modified
os/os-scrollbar.c (+99/-6) |
To merge this branch: | bzr merge lp://staging/~cimi/overlay-scrollbar/align-thumb-position |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ted Gould (community) | Approve | ||
Review via email: mp+79701@code.staging.launchpad.net |
Description of the change
Align the thumb to the pageup when you're revealing it at top, pagedown at bottom
To post a comment you must log in.
The code looks fine, but it would be best in future revisions to start de-duplicating the code using inline functions. It would increase the maintainability of the code.