Code review comment for lp://staging/~chris.macnaughton/openstack-mojo-specs/upgrade-spec

Need to fix linting errors. I expect this might be challenging as most of them are due to long lines in the bash snippets.

> Most (all?) juju ssh $UNIT sudo $CMD should be juju run --unit $UNIT $CMD. You get root for free and various --format output options more convenient for python.

The do-release-upgrade and the loop check after reboot makes sense to use SSH. The others, reboot and lsb_release check, make more sense as juju run.

Note: it turns out juju run --unit runs as root but juju run --machine runs as ubuntu user. Just for consistency.

> A number of WIP print statements that either need logging statements or removal before landing. Not also the use of logging.error or logging.warn where appropriate.

Still true. Some are commented but they should be removed or made logging statements. Use of logging.error and logging.warn suggestions still in effect.