Code review comment for lp://staging/~chris.macnaughton/charms/trusty/kibana/version_bump

Revision history for this message
Andrew McLeod (admcleod) wrote :

Hi Chris,

I've re-run bundletester on this in AWS and it all looks good until test 11 - the deployment is OK, I can access kibana GUI, however test 11 then tries to access kibana on port 9200 and times out:

Test 11:

url = 'http://%s:9200/_all/_search' % kibana_unit.info['public-address']
(diff comment line 412)

Test 12:

Also I set -F for bundletester so it continued with the tests - the next kibana service is deployed as kibana/2, but test 12 is looking for kibana/0:

kibana_unit = d.sentry.unit['kibana/0']

Perhaps you could use d.sentry['kibana'][0] to get the first kibana unit deployed?

bundletester output: http://pastebin.ubuntu.com/12894780/

review: Needs Fixing

« Back to merge proposal