Code review comment for lp://staging/~chris-gondolin/charms/trusty/storage/trunk
Revision history for this message
| Tim Van Steenburgh (tvansteenburgh) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
2eb648a
demo site
(Get the code!)
Hey Chris, nice addition to the storage charm, thanks!
My only quibble with this proposal is that there are no new tests to cover the new functionality. Before giving this a +1 I would like to see some tests to cover the new encryption stuff - maybe some unit test coverage of the crypt_fs module, and a new amulet test to test a deployment scenario.