Code review comment for lp://staging/~charlesk/libappindicator/lp-931764

Revision history for this message
Ted Gould (ted) wrote :

Hmm, have no clue why make distcheck passed then. But, I don't care, these changes look good.

Only thing is that when I merge them I'm going to change the layout a bit. It should be done using bzr mv instead of deleting the files and adding new ones. Since Bazaar has strong file IDs this means that if other people had branches modifying these files in some other way Bazaar could resolve the conflicts. If there's no shared history it can't do that.

review: Approve

« Back to merge proposal