Merge lp://staging/~charlesk/indicator-transfer/rtm-usability-fix into lp://staging/indicator-transfer/14.10

Proposed by Charles Kerr
Status: Merged
Approved by: Ted Gould
Approved revision: 29
Merged at revision: 22
Proposed branch: lp://staging/~charlesk/indicator-transfer/rtm-usability-fix
Merge into: lp://staging/indicator-transfer/14.10
Diff against target: 229 lines (+154/-7)
3 files modified
src/view-gmenu.cpp (+15/-3)
tests/manual (+12/-3)
tests/test-view-gmenu.cpp (+127/-1)
To merge this branch: bzr merge lp://staging/~charlesk/indicator-transfer/rtm-usability-fix
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Ted Gould (community) Approve
Review via email: mp+237111@code.staging.launchpad.net

Commit message

Change the indicator's label to "Files" and only show the indicator if there are unfinished transfers.

Description of the change

== Description of Change

Update label and visibility to match changes listed in <https://docs.google.com/a/canonical.com/document/d/1jHIGzAzf7kFELgOiU9J0Hd9mOa3NzTsnEglLmx_qEfk/edit#>:

1. Change the title from "Transfers" to "Files"

2. Change the visibility behavior s.t. the indicator is only visible when there are incomplete transfers.

== Checklist

> Are there any related MPs required for this MP to build/function as expected? Please list.

No

> Is your branch in sync with latest trunk? (e.g. bzr pull lp:trunk -> no changes)

Yes

> Did the code build without warnings?

Yes

> Did the tests run successfully?

Yes

> Did you perform an exploratory manual test run of your code change and any related functionality?

Yes

> Has your component test plan been executed successfully on emulator or a physical device?

Yes, mako + r68

> Please list which manual tests are germane for the reviewer in this MP.

indicator-transfer/visibility

> Did you link to the checklist URL at https://wiki.ubuntu.com/Process/Merges/Checklists/indicator-transfer to make life easier for reviewers/testers?

Yes

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) wrote :

Small stuff, I'll mark approved but not top approve.

review: Approve
26. By Charles Kerr

fix questionable use of 'const auto'

27. By Charles Kerr

fix syntax error in manual tests

28. By Charles Kerr

in test-view-gmenu's PhoneHeader test, improve local variablenames

29. By Charles Kerr

in test-view-gmenu.cpp, extract copy-and-pasted blocks into a function to reduce duplicated code

Revision history for this message
Charles Kerr (charlesk) wrote :

Fixed; comments inline

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches