Merge lp://staging/~charlesk/indicator-transfer/rtm-usability-fix into lp://staging/indicator-transfer/14.10
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Ted Gould | ||||||||
Approved revision: | 29 | ||||||||
Merged at revision: | 22 | ||||||||
Proposed branch: | lp://staging/~charlesk/indicator-transfer/rtm-usability-fix | ||||||||
Merge into: | lp://staging/indicator-transfer/14.10 | ||||||||
Diff against target: |
229 lines (+154/-7) 3 files modified
src/view-gmenu.cpp (+15/-3) tests/manual (+12/-3) tests/test-view-gmenu.cpp (+127/-1) |
||||||||
To merge this branch: | bzr merge lp://staging/~charlesk/indicator-transfer/rtm-usability-fix | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
Ted Gould (community) | Approve | ||
Review via email: mp+237111@code.staging.launchpad.net |
Commit message
Change the indicator's label to "Files" and only show the indicator if there are unfinished transfers.
Description of the change
== Description of Change
Update label and visibility to match changes listed in <https:/
1. Change the title from "Transfers" to "Files"
2. Change the visibility behavior s.t. the indicator is only visible when there are incomplete transfers.
== Checklist
> Are there any related MPs required for this MP to build/function as expected? Please list.
No
> Is your branch in sync with latest trunk? (e.g. bzr pull lp:trunk -> no changes)
Yes
> Did the code build without warnings?
Yes
> Did the tests run successfully?
Yes
> Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
> Has your component test plan been executed successfully on emulator or a physical device?
Yes, mako + r68
> Please list which manual tests are germane for the reviewer in this MP.
indicator-
> Did you link to the checklist URL at https:/
Yes
PASSED: Continuous integration, rev:25 jenkins. qa.ubuntu. com/job/ indicator- transfer- ci/12/ jenkins. qa.ubuntu. com/job/ indicator- transfer- utopic- amd64-ci/ 12 jenkins. qa.ubuntu. com/job/ indicator- transfer- utopic- armhf-ci/ 12 jenkins. qa.ubuntu. com/job/ indicator- transfer- utopic- armhf-ci/ 12/artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/indicator- transfer- ci/12/rebuild
http://