lp://staging/~charlesk/indicator-transfer/rtm-usability-fix

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/indicator-transfer/14.10 at revision 22

PS Jenkins bot (community): Approve (continuous-integration) on 2014-10-03

Ted Gould (community): Approve on 2014-10-03

Diff: 229 lines (+154/-7)

3 files modified

src/view-gmenu.cpp (+15/-3)
tests/manual (+12/-3)
tests/test-view-gmenu.cpp (+127/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1377275: Indicators should only be visible if they contain data	High	Fix Released
Bug #1377286: Update Indicator Title Strings	High	Fix Released

Link a bug report

Related blueprints

29. By Charles Kerr on 2014-10-03

in test-view-gmenu.cpp, extract copy-and-pasted blocks into a function to reduce duplicated code

28. By Charles Kerr on 2014-10-03

in test-view-gmenu's PhoneHeader test, improve local variablenames

27. By Charles Kerr on 2014-10-03

fix syntax error in manual tests

26. By Charles Kerr on 2014-10-03

fix questionable use of 'const auto'

25. By Charles Kerr on 2014-10-03

add manual test indicator-transfer/visibility

24. By Charles Kerr on 2014-10-03

fix tyop in test comment

23. By Charles Kerr on 2014-10-03

update manual test to reflect new visibility behavior

22. By Charles Kerr on 2014-10-03

add unit tests for phone header, esp. visibility tests

21. By Charles Kerr on 2014-10-03

change indicator to be visible only if there are incomplete transfers.

20. By Charles Kerr on 2014-10-03

change header title from 'Transfers' to 'Files'