Code review comment for lp://staging/~charlesk/indicator-datetime/remove-unneeded-dependencies

Revision history for this message
Sebastien Bacher (seb128) wrote :

> In debian/rules, don't override_dh_install. This needs another pair of eyes to confirm, but but none of the other indicators use anything like the rule being removed.

Thanks Charles, those changes look good! The intltool/gettext domain work is indeed not needed since the package use dh_translations (--with translations being listed in rules). You need to keep the override section with the "dh_install --fail-missing" line though. That lines makes the build stop if new files are installed by "make install" but not ending in any .deb, that allows us to not overlook installing new files when we get some

review: Needs Fixing

« Back to merge proposal