Code review comment for lp://staging/~chad.smith/landscape-client/swift-device-monitoring

Looks good! +1

Just minor comments:

#1:
+ When the plugin has no data, it's various create_X_message()

typo "it's" -> "its"

#2:
+ def test_messages(self):

+ def test_messages_with_swift_data(self):

These two same to perform the same test. The docstring for the latter seems more precise than the other one.

#3:
+ self._swift_device_info_to_persist = None

I think you could set this to an empty list, so that it's valid even if not initialized elsewhere.