Code review comment for lp://staging/~chad.smith/charms/trusty/nrpe/trunk

Revision history for this message
Stuart Bishop (stub) wrote :

There is still a test failing, unless run against a freshly bootstrapped environment, due to a hard coded unit number. This is still landable, as *all* the tests currently fail on trunk unless run against a freshly bootstrapped environment.

$ tests/10-tests
2016-02-04 11:20:37 Starting deployment of local
2016-02-04 11:20:37 Deploying services...
2016-02-04 11:20:37 Deploying service mysql using cs:trusty/mysql-33
2016-02-04 11:20:40 Deploying service nrpe using /tmp/charmqWiN9t/trusty/trunk
2016-02-04 11:21:48 Config specifies num units for subordinate: nrpe
2016-02-04 11:22:14 Adding relations...
2016-02-04 11:22:14 Adding relation nrpe:monitors <-> nagios:monitors
2016-02-04 11:22:14 Adding relation nrpe:local-monitors <-> mysql:local-monitors
2016-02-04 11:23:19 Exposing service 'nagios'
2016-02-04 11:23:19 Deployment complete in 162.00 seconds
.............E..
======================================================================
ERROR: test_nagios_host_context (__main__.TestDeployment)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/10-tests", line 227, in test_nagios_host_context
    self.check_nrpe_setting(**test_config)
  File "tests/10-tests", line 42, in check_nrpe_setting
    nrpe_contents = self.nrpe_sentry.file_contents(filename)
  File "/usr/lib/python2.7/dist-packages/amulet/sentry.py", line 92, in file_contents
    raise IOError(output)
IOError: cat: /var/lib/nagios/export/host__bob-mysql-0.cfg: No such file or directory

----------------------------------------------------------------------
Ran 16 tests in 755.998s

« Back to merge proposal