Code review comment for lp://staging/~chad.smith/charms/precise/storage/storage-nfs-python-provider

Revision history for this message
David Britton (dpb) wrote :

== common_util.py ==

[20] I think you can remove the guts of the log function, and just have it do

return hookenv.log(message, level). It seems to handle the 'None' case already

[21] RE: TODO: you don't need to check files existing "below" a mount. mount doesn't care, it will happily eclipse them (not remove them). Once the device is unmounted, the files will be visible again.

+1, I'll test and review further on Jerry's Branch. :)

review: Approve

« Back to merge proposal