Code review comment for lp://staging/~chad.smith/charms/precise/storage/storage-nfs-python-provider

Revision history for this message
Chad Smith (chad.smith) wrote :

Resolved dpb's
15: docs added
16: get_volume_id will exit in error if multiple potential volume candidates are discovered for this unit through nova volume-list

17: attach_nova_volume will only proceed if volume status is "available" and exit in error for other status
18:
[18] leaving subprocess.call as we do check the exit code. it just doesn't traceback for us like check_call would have

« Back to merge proposal