Juju Charms Collection
storage package

Code review comment for lp://staging/~chad.smith/charms/precise/storage/storage-nfs-python-provider

  1. Precise Pangolin (12.04)
  2. storage-nfs-python-provider
  3. Merge into trunk
Revision history for this message
David Britton (dpb) wrote :

[7] in common_util:mount_volume, you are reading persisted data from the
nfs relation. Instead of doing this, I wonder if you should instead use
the relation-get concept of probing the relation to get that data.

It's something like:

    ids=$(relation-ids --type nfs)
    relation-get --id <id>

I'll leave it to you to decide if this is a direction you want to go.

--
David Britton <email address hidden>

« Back to merge proposal