Checkbox

Merge lp://staging/~cgregan/checkbox/times-update-local into lp://staging/checkbox

times-update-local
Merge into trunk

Proposed by Chris Gregan on 2014-03-20

Status:	Rejected
Rejected by:	Zygmunt Krynicki on 2014-08-04
Proposed branch:	lp://staging/~cgregan/checkbox/times-update-local
Merge into:	lp://staging/checkbox
Diff against target:	218 lines (+25/-2) 6 files modified checkbox-old/jobs/ethernet.txt.in (+4/-0) checkbox-old/jobs/graphics.txt.in (+10/-2) checkbox-old/jobs/networking.txt.in (+6/-0) checkbox-old/jobs/suspend.txt.in (+2/-0) checkbox-old/jobs/usb.txt.in (+1/-0) checkbox-old/jobs/wireless.txt.in (+2/-0)
To merge this branch:	bzr merge lp://staging/~cgregan/checkbox/times-update-local
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Zygmunt Krynicki (community)		Disapprove on 2014-08-04
Daniel Manrique (community)	2014-03-20	Needs Fixing on 2014-03-20
Review via email: mp+211935@code.staging.launchpad.net

Revision history for this message

Daniel Manrique (roadmr) wrote on 2014-03-20:

SOme local tests (see the ones at the beginning) have a duration of 10 seconds, while the ones at the end have 0.250 seconds. We should standardize them all. Remember this is only the local job that generates the sub-jobs; the subjobs themselves have their own duration specified elsewhere.

review: Needs Fixing

Revision history for this message

Daniel Manrique (roadmr) wrote on 2014-04-03:

In the time since this MR, a lot of the tests were updated with estimated_duration. It's probably worth revisiting this and leaving only the ones that don't already have a duration. Just so it doesn't go into "merge request hell" and stays here for years.

Revision history for this message

Zygmunt Krynicki (zyga) wrote on 2014-08-04:

Rejecting, please re-post if you have any updates

review: Disapprove