Merge lp://staging/~celebdor/charms/precise/cassandra/hostname_resolve into lp://staging/charms/cassandra

Proposed by Antoni Segura Puimedon
Status: Merged
Approved by: Matt Bruzek
Approved revision: 42
Merged at revision: 39
Proposed branch: lp://staging/~celebdor/charms/precise/cassandra/hostname_resolve
Merge into: lp://staging/charms/cassandra
Diff against target: 64 lines (+22/-1)
2 files modified
config.yaml (+5/-0)
hooks/cassandra-common (+17/-1)
To merge this branch: bzr merge lp://staging/~celebdor/charms/precise/cassandra/hostname_resolve
Reviewer Review Type Date Requested Status
Matt Bruzek (community) Approve
Charles Butler Pending
Review via email: mp+257120@code.staging.launchpad.net

Description of the change

see commit msg.

To post a comment you must log in.
Revision history for this message
Matt Bruzek (mbruzek) wrote :

Hello Antoni,

Thank you for submitting this fix. It is my understanding this fix allows cassandra to be installed on LXC.

The code adds a configuration option that is only evaluated at install time. If the customer were to change the package_version after install the operation would have no effect. This is what we call "immutable configuration". This is because "config-changed" is the only hook called when the Juju user changes the configuration in the GUI or on the command line.

If you are going to add a configuration option like this I would like to see the configuration option read and reacted in the "configure_cassandra" function of the hooks/cassandra-common file.

You can keep the code in the "install" function but need to add it to something that will be called on "config-changed".

Please let me know when you are ready for another review.

Thanks!

review: Needs Fixing
Revision history for this message
Matt Bruzek (mbruzek) wrote :

I can confirm that deploying with the following configuration created a precise with cassandra version 2.0.10 installed.

cassandra:
   allow-single-node: True
   cluster-name: midonet
   apt-repo-spec: "deb http://debian.datastax.com/community stable main"
   apt-repo-key: "7E41C00F85BFC1706C4FFFB3350200F2B999A372"
   extra_packages: "openjdk-7-jre-headless dsc20=2.0.10-1"
   package_version: "2.0.10"

+1 LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches