Merge lp://staging/~ce-infrastructure/capomastro/capomastro-defaults-1389823 into lp://staging/capomastro

Proposed by Caio Begotti
Status: Merged
Approved by: Daniel Manrique
Approved revision: 150
Merged at revision: 149
Proposed branch: lp://staging/~ce-infrastructure/capomastro/capomastro-defaults-1389823
Merge into: lp://staging/capomastro
Diff against target: 61 lines (+20/-1)
4 files modified
debian/changelog (+6/-0)
projects/templates/projects/dependency_detail.html (+8/-0)
projects/tests/test_views.py (+1/-1)
projects/views.py (+5/-0)
To merge this branch: bzr merge lp://staging/~ce-infrastructure/capomastro/capomastro-defaults-1389823
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Sheila Miguez (community) Approve
Review via email: mp+243716@code.staging.launchpad.net

Description of the change

There was a typo in the XML tags that prevented parameters from being listed in the form view of dependencies and that was fixed properly, but pushed by accident directly to lp:bygmester/android-barajas. Which is okay now since these changes here are the rest of the fix for https://bugs.launchpad.net/capomastro/+bug/1389823 and the typo fix was needed anyway.

The accidental push is https://bazaar.launchpad.net/~ce-infrastructure/bygmester/android-barajas/revision/68

To post a comment you must log in.
Revision history for this message
Sheila Miguez (codersquid) wrote :

Looks okay to merge

review: Approve
Revision history for this message
Daniel Manrique (roadmr) wrote :

+1 from me too, see two small nitpicks but not important enough to hold this; they're actually just me being curious about django workings. So I'll approve this and see what tarmac thinks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches