Code review comment for lp://staging/~canonical-platform-qa/ubuntu-ota-tests/check-for-running-service

Revision history for this message
Barry Warsaw (barry) wrote :

Comments inline.

I like the way you've created a package for utilities to live in. We should definitely do that. Also, I think it's perfectly fine to import things from the systemimage package. There's a lot of useful utilities there, such as systemimage.reactor.Reactor, and since this is the SUT, I think it's perfectly acceptable to use them when appropriate.

(Note, in the case where you locate the system-image-dbus process, si has a similar utility, but it's semantics are somewhat different, so it's not a perfect fit.)

review: Needs Fixing

« Back to merge proposal