messaging-app

Merge lp://staging/~canonical-platform-qa/messaging-app/new_helpers_tests into lp://staging/messaging-app

new_helpers_tests
Merge into trunk

Proposed by Brendan Donegan on 2014-07-15

Status:	Work in progress
Proposed branch:	lp://staging/~canonical-platform-qa/messaging-app/new_helpers_tests
Merge into:	lp://staging/messaging-app
Diff against target:	110 lines (+67/-1) 3 files modified tests/autopilot/messaging_app/emulators.py (+4/-0) tests/autopilot/messaging_app/helpers.py (+14/-0) tests/autopilot/messaging_app/tests/test_messaging.py (+49/-1)
To merge this branch:	bzr merge lp://staging/~canonical-platform-qa/messaging-app/new_helpers_tests
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot	continuous-integration	2014-07-15	Needs Fixing on 2014-07-15
Leo Arias (community)		2014-07-15	Needs Fixing on 2014-07-15
Gustavo Pichorim Boiko		2014-07-15	Pending
Review via email: mp+226825@code.staging.launchpad.net

This proposal supersedes a proposal from 2014-07-11.

Description of the change

This branch contains some new tests which exercise the helpers that I created to aid in the automation of the 'Add number to contact from message' user experience. To some extent they replicate the intent of that test, but do not actually concern themselves with the integration of the messaging-app and address-book-app - they just check that address-book-app does the right thing in the case of each function.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-11: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:140
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~brendan-donegan/messaging-app/new_helpers_tests/+merge/226439/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/messaging-app-ci/280/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1854/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1552/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-amd64-ci/74/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-armhf-ci/74/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-i386-ci/74/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2949/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1742/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/280/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Leo Arias (elopio) wrote on 2014-07-11: Posted in a previous version of this proposal

102 + address_book = get_proxy_object_for_existing_process(
103 + pid=helpers.get_pid_by_name('address-book-app'))
104 + self.assertNotEqual(address_book, None)

we shouldn't add address book as a dependency to those tests.
what we should do is to check that url-dispatcher has received the right message.

review: Needs Fixing (code review)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-11: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:140
http://jenkins.qa.ubuntu.com/job/messaging-app-ci/281/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1876/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1568/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-amd64-ci/75/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-armhf-ci/75/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-i386-ci/75/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2973/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1758/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/281/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Gustavo Pichorim Boiko (boiko) wrote on 2014-07-15: Posted in a previous version of this proposal

The test_add_phone_number_to_new_contact needs to be disabled on desktop as it only works on the device.

review: Needs Fixing

Revision history for this message

Leo Arias (elopio) wrote on 2014-07-15:

78 + self.main_view.click_add_button()
79 + self.main_view.click_add_to_contact_button()
80 + add_to_contact = self.main_view.get_add_phone_number_to_contact_page()

Please wrap this in a higher level helper called add_phone_number_to_existing_contact.

98 + self.main_view.click_add_button()
103 + self.main_view.click_create_new_contact_button()

And this into one called something like go_to_create_new_contact.

104 + address_book = get_proxy_object_for_existing_process(
105 + pid=helpers.get_pid_by_name('address-book-app'))

Please remove the dependency on address-book-app by copying the fake url dispatcher, or by waiting for url-dispatcher-testability to land.

review: Needs Fixing

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-15:

FAILED: Continuous integration, rev:141
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~canonical-platform-qa/messaging-app/new_helpers_tests/+merge/226825/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/messaging-app-ci/290/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2025/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1699/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-amd64-ci/84/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-armhf-ci/84/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-i386-ci/84/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3151/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1908/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/290/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

141. By Brendan Donegan on 2014-07-15: Add skipIf to test_add_phone_number_to_new_contact as the test is not supported on the desktop
140. By Brendan Donegan on 2014-07-11: Make sure that address-book-app is launched when we try to add a number to a new contact
139. By Brendan Donegan on 2014-07-11: Remove proxy for AddPhoneNumberToContactPage because it isn't ready to be tested.
138. By Brendan Donegan on 2014-07-11: Add tests for toolbar button helpers