messaging-app

Merge lp://staging/~brendan-donegan/messaging-app/new_helpers_tests into lp://staging/messaging-app

  1. new_helpers_tests
  2. Merge into trunk
Proposed by Brendan Donegan
Status: Superseded
Proposed branch: lp://staging/~brendan-donegan/messaging-app/new_helpers_tests
Merge into: lp://staging/messaging-app
Diff against target: 108 lines (+65/-1)
3 files modified
tests/autopilot/messaging_app/emulators.py (+4/-0)
tests/autopilot/messaging_app/helpers.py (+14/-0)
tests/autopilot/messaging_app/tests/test_messaging.py (+47/-1)
To merge this branch: bzr merge lp://staging/~brendan-donegan/messaging-app/new_helpers_tests
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Needs Fixing
PS Jenkins bot continuous-integration Needs Fixing
Leo Arias (community) code review Needs Fixing
Review via email: mp+226439@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2014-07-15.

Commit message

Add some tests for helpers for the 'Add number to contact' dialog

Description of the change

This branch contains some new tests which exercise the helpers that I created to aid in the automation of the 'Add number to contact from message' user experience. To some extent they replicate the intent of that test, but do not actually concern themselves with the integration of the messaging-app and address-book-app - they just check that address-book-app does the right thing in the case of each function.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:140
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~brendan-donegan/messaging-app/new_helpers_tests/+merge/226439/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/messaging-app-ci/280/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1854/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1552/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-amd64-ci/74/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-armhf-ci/74/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-i386-ci/74/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2949/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1742/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/280/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Leo Arias (elopio) wrote :

102 + address_book = get_proxy_object_for_existing_process(
103 + pid=helpers.get_pid_by_name('address-book-app'))
104 + self.assertNotEqual(address_book, None)

we shouldn't add address book as a dependency to those tests.
what we should do is to check that url-dispatcher has received the right message.

review: Needs Fixing (code review)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:140
http://jenkins.qa.ubuntu.com/job/messaging-app-ci/281/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1876/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/1568/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-amd64-ci/75/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-armhf-ci/75/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/messaging-app-utopic-i386-ci/75/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2973/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/1758/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/messaging-app-ci/281/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

The test_add_phone_number_to_new_contact needs to be disabled on desktop as it only works on the device.

review: Needs Fixing

Unmerged revisions

140. By Brendan Donegan

Make sure that address-book-app is launched when we try to add a number to a new contact

139. By Brendan Donegan

Remove proxy for AddPhoneNumberToContactPage because it isn't ready to be tested.

138. By Brendan Donegan

Add tests for toolbar button helpers

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches