Juju Charms Collection
squid-reverseproxy package

Code review comment for lp://staging/~canonical-losas/charms/trusty/squid-reverseproxy/venv-testing

  1. Trusty Tahr (14.04)
  2. venv-testing
  3. Merge into trunk
Revision history for this message
Adam Israel (aisrael) wrote :

Hi Paul,

Thanks for your efforts to improve the testing story for this charm! I had the chance to review your merge proposal today. Adding virtualenv is a welcome addition here.

I ran into a few issues that I wanted to bring to your attention, though. While the venv is created, the Makefile continues to use the system python, installing packages globally. Once the venv is created, it should run commands from the `.venv/bin` directory, i.e., `.venv/bin/python`, `.venv/bin/pip`. With that, I also ran into version errors with pep8.

I reworked the Makefile to install and use the venv, and put the code here for reference:
https://code.launchpad.net/~aisrael/charms/trusty/squid-reverseproxy/rework_venv

With those issues above resolved, I see no problem getting these changes moved forward. Thanks again for your efforts! Just set this back to 'Needs Review' when you're ready for us to take another look.

review: Needs Fixing

« Back to merge proposal