Code review comment for lp://staging/~canonical-isd-hackers/django-preflight/gargoyle

Revision history for this message
Ricardo Kirkner (ricardokirkner) wrote :

Some ideas for improvements

- rename gather_gargoyle to gather_switches/gather_flags or gather_feature_flags to make it not gargoyle specific and
a) test for gargoyle availability in the default implementation or b) do the actual implementation in the app that uses preflight (which knows whether they use gargoyle or something else)

- rename "Gargoyle" in l.91 to something more generic

- l.141-143 change the wording so that it's more generic and doesn't depend on gargoyle specifically (or place inside the {% if gargoyle %} so that we don't even show the section if it's empty)

- the django version check should be
django >= 1.4, django < 1.5

« Back to merge proposal