Canonical SSO provider

Code review comment for lp://staging/~canonical-isd-hackers/canonical-identity-provider/redirect-url

  1. redirect-url
  2. Merge into trunk
Revision history for this message
Danny Tamez (zematynnad) wrote :

Looks great - just some nit picks...
typo on line 12 of the diff withing
is the test_test_ thing on lines 181 and 185 on purpose?
please put line 259 after 261 and remove the unused import on line 11 of identityprovider/views/ui.py

review: Needs Fixing

« Back to merge proposal