Code review comment for lp://staging/~canonical-isd-hackers/canonical-identity-provider/bug_507214_remove_email

Revision history for this message
Ricardo Kirkner (ricardokirkner) wrote :

All looks very well. Only one comment. Instead of using the Q object for the OR query, it should be possible to use the __in operator (like email_set.filter(status__in=(PREFERRED, VALIDATED)))

Since this change is not really important, but a matter of taste, I approve the mp already. If you want, change it, otherwise, do not :)

review: Approve

« Back to merge proposal