Code review comment for lp://staging/~caio1982/ubuntu-system-image/remote-sis-generator-skips-metadata

Revision history for this message
Barry Warsaw (barry) wrote :

On Jun 02, 2015, at 09:05 PM, Caio Begotti wrote:

>Thanks, Barry! Just filed
>https://bugs.launchpad.net/ubuntu-system-image/+bug/1461263 for the encoding
>bit.

Thanks!

>It might take me a while to write tests for this MR though as I honestly
>don't know the code much and I see all the other generators are missing tests
>for metadata (at least for version_detail) and they should have some.

Yep. You can't get to 100% in one fell swoop, but every new test is an
investment in the future quality of the project.

« Back to merge proposal