Code review comment for lp://staging/~caio1982/capomastro/fix-billiard-dhpython

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

It feels wrong that this is on an indirect dependency but feel free to
do it this way.

On Thu, May 7, 2015 at 6:33 PM, Daniel Manrique
<email address hidden> wrote:
> Review: Approve
>
> OHH I see. The description says this:
>
> to use Billiard 3.0.18-2, which has been backported by me, ans not 3.3.0.15
>
> It should say this:
>
> to use Billiard 3.3.0.18-2, which has been backported by me, ans not 3.3.0.15
>
> (so 3.0.18 seemed older than 3.3.0.15, but 3.3.0.18 is clearly newer).
>
> I'll fix the description in a second.
>
> +1 from me, I'll give a bit for Zygmunt to comment on the pydist stuff but your explanation (and the commit message) make sense.
> --
> https://code.launchpad.net/~caio1982/capomastro/fix-billiard-dhpython/+merge/258525
> You are subscribed to branch lp:capomastro.

« Back to merge proposal