Code review comment for lp://staging/~caio1982/capomastro/celery-fixes

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Hey. Three observations:

- Use a more readable commit message pattern with the summary separate from the description. This is standard practice and it helps for readability and changelog maintenance. Use proper capitalization for sentences. Use sentences instead of a long chain of commas. This might seem picky but looking at the commit messages just makes them look sloppy to me.
- Using database as as scheduler is a hack IMHO. It's a busy loop (with a sleep inside) that just keeps poking the database. I suspect using rabbit is a standard practice in Canonical and using it would definitely cut the load on the database as it's purely event based.
- Using --concurrency=1 to fix issues also feels very much wrong. Defunct processes are just zombies. I suspect that using concurrency=1 just runs everything in the master process so you don't get zombies but this just hides the real problem.

Thanks
ZK

« Back to merge proposal