Code review comment for ~bryce/ubuntu/+source/dovecot:sru-lp1991564-jammy

Hi Bryce, Thanks for working on this one :)

The packaging side of this MP LGTM.

It's also nice that the package has some DEP8 tests and runs the upstream unit test suite during build time to give us more confidence on the regressions issue.

As for the SRU template, there is one bit that got my attention:

> User testing in production can be of value, since the principle impact is the side effects from hitting the fatal error, rather than the error itself.

I wonder if this should be an opt-in "feature" for users, since jammy is an LTS release. This could be done by staging the SRU (block-proposed) and inviting users to test the package for a while (we should expect that at least the reporter should test the changes).

However, there will still be the "risk" that we need to push another change to the package (a high priority bug or CVE) soon after this patch set lands in -proposed and the patch ends up landing in the updates/security pocket right away. Forcing users to perform production tests to ensure we are not adding regressions here.

Either way, this should be something for the SRU team to evaluate.

LGTM!