ppa-dev-tools

Merge ppa-dev-tools:cleanup-tox-lint into ppa-dev-tools:main

  1. Git
  2. lp:ppa-dev-tools
  3. cleanup-tox-lint
  4. Merge into main
Proposed by Bryce Harrington
Status: Merged
Merged at revision: 7bef7a0bbf5a634d9ea9e9e1a04dfebce5f7d4ff
Proposed branch: ppa-dev-tools:cleanup-tox-lint
Merge into: ppa-dev-tools:main
Diff against target: 1352 lines (+176/-157)
26 files modified
ppa/binary_package.py (+3/-3)
ppa/constants.py (+1/-1)
ppa/debug.py (+3/-3)
ppa/dict.py (+5/-5)
ppa/io.py (+1/-1)
ppa/job.py (+10/-9)
ppa/lp.py (+5/-6)
ppa/ppa.py (+27/-25)
ppa/ppa_group.py (+8/-7)
ppa/processes.py (+17/-17)
ppa/repository.py (+5/-4)
ppa/result.py (+17/-17)
ppa/source_package.py (+5/-5)
ppa/subtest.py (+7/-6)
ppa/suite.py (+8/-7)
ppa/text.py (+13/-10)
ppa/trigger.py (+6/-5)
scripts/ppa (+23/-17)
setup.py (+1/-1)
tests/helpers.py (+2/-0)
tests/test_job.py (+1/-1)
tests/test_lp.py (+1/-1)
tests/test_result.py (+1/-1)
tests/test_scripts_ppa.py (+2/-1)
tests/test_subtest.py (+1/-1)
tests/test_trigger.py (+3/-3)
Reviewer Review Type Date Requested Status
Lena Voytek (community) Approve
PpaDevTools Developers Pending
Canonical Server Reporter Pending
Review via email: mp+449388@code.staging.launchpad.net

Description of the change

This is a collection of lint, tox, etc. cleanups I've collected as I prepare for the 0.5 release. I'm submitting this separately from feature branches for ease of reviewing.

I have a goal of eventually making ppa-dev-tools pass tox without issue, however there's a lot of tox output to go through, so this is just a start. However, the rest of these cleanups address pylint, etc. issues to a degree that it should make the codebase lint-clean. The linter is run as part of the testsuite, so:

  $ make check

To post a comment you must log in.
Revision history for this message
Lena Voytek (lvoytek) wrote :

I found two variable instances that were left behind in the naming update, marked them in the diff comments. Otherwise everything here looks good to me! The local variable names seem descriptive enough within context. Function descriptions also look good, added one small nitpick though

review: Needs Fixing
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks, updated the branch with those changes, squashed, and force-pushed an update to this branch.

Revision history for this message
Lena Voytek (lvoytek) wrote :

Sweet, LGTM!

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Landed, thanks again.

stirling: ~/src/PpaDevTools/ppa-dev-tools-packaging$ git merge --ff-only cleanup-tox-lint
Updating eb2d241..7bef7a0
Fast-forward
 ppa/binary_package.py | 6 +++---
 ppa/constants.py | 2 +-
 ppa/debug.py | 6 +++---
 ppa/dict.py | 10 +++++-----
 ppa/io.py | 2 +-
 ppa/job.py | 19 ++++++++++---------
 ppa/lp.py | 11 +++++------
 ppa/ppa.py | 52 +++++++++++++++++++++++++++-------------------------
 ppa/ppa_group.py | 15 ++++++++-------
 ppa/processes.py | 34 +++++++++++++++++-----------------
 ppa/repository.py | 9 +++++----
 ppa/result.py | 34 +++++++++++++++++-----------------
 ppa/source_package.py | 10 +++++-----
 ppa/subtest.py | 13 +++++++------
 ppa/suite.py | 15 ++++++++-------
 ppa/text.py | 23 +++++++++++++----------
 ppa/trigger.py | 11 ++++++-----
 scripts/ppa | 40 +++++++++++++++++++++++-----------------
 setup.py | 2 +-
 tests/helpers.py | 2 ++
 tests/test_job.py | 2 +-
 tests/test_lp.py | 2 +-
 tests/test_result.py | 2 +-
 tests/test_scripts_ppa.py | 3 ++-
 tests/test_subtest.py | 2 +-
 tests/test_trigger.py | 6 +++---
 26 files changed, 176 insertions(+), 157 deletions(-)
stirling: ~/src/PpaDevTools/ppa-dev-tools-packaging$ git push
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To git+ssh://git.launchpad.net/ppa-dev-tools
   eb2d241..7bef7a0 main -> main

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: