Code review comment for lp://staging/~bryce/launchpad/lp-796645-cron-dies-on-404

Revision history for this message
Curtis Hovey (sinzui) wrote :

> === modified file 'lib/lp/bugs/scripts/bzremotecomponentfinder.py'
> --- lib/lp/bugs/scripts/bzremotecomponentfinder.py 2011-06-02 22:27:11 +0000
> +++ lib/lp/bugs/scripts/bzremotecomponentfinder.py 2011-07-01 02:59:24 +0000
...
> + try:
> + self.logger.debug("...Fetching page")
> + page_text = bz_bugtracker.getPage()
> + except HTTPError, error:
> + self.logger.error("Error fetching %s: %s" % (
> + lp_bugtracker.baseurl, error))
> + continue
> + except:
> + self.logger.error("Failed to access %s" % (
> + lp_bugtracker.baseurl))
> + continue

We logged code failures, or failures we can fix as errors, we issues with
other sites as warnings. The faults I saw in testing were dead sites or
bad user data...I do not think these cases are errors.

review: Needs Information (code)

« Back to merge proposal