Code review comment for lp://staging/~bryce/launchpad/lp-617679-db

Revision history for this message
Robert Collins (lifeless) wrote :

OMMENT ON COLUMN BugTrackerComponent.is_active IS 'Whether to display or hide the item in the Launchpad user interface.';

perhaps is_shown, if that is what you mean.

If you mean that bugwatches etc will ignore it in future, then the comment is wrong. Either way something is mismatched.

I don't parse ." Some bug trackers do not group components thus all BugTrackerComponents will belong to a default componentgroup.';" easily; could you consider expanding or rephrasing. For instance, do you mean 'one default componentgroup for all trackers'.

source_package->distro_source_package please, for clarity

If these are going to be shown in LP, and traversed to, they have to have a constraint on the name to match our url restrictions; if they aren't, then you may have some difficulty writing uis for them. If the contstraint will conflict with external names (e.g. someone has a component called Foo and the capital letter matters), then you need two fields: a field for LP to use and a field for the external tracker. (Or, don't ever traverse to these things in the web UI/API).

review: Approve (database)

« Back to merge proposal