git-ubuntu

Merge ~bryce/git-ubuntu:systemd-service into git-ubuntu:master

Proposed by Bryce Harrington on 2019-10-29

Status:	Superseded
Proposed branch:	~bryce/git-ubuntu:systemd-service
Merge into:	git-ubuntu:master
Diff against target:	141 lines (+63/-16) 4 files modified doc/README.testing (+3/-0) setup.py (+1/-1) snap-wrappers/wrappers/git-ubuntu-self-test (+56/-13) snap/snapcraft.yaml (+3/-2)
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Server Team CI bot	continuous-integration	2019-10-29	Needs Fixing on 2019-10-29
Robie Basak		2019-10-29	Pending
Review via email: mp+374868@code.staging.launchpad.net

This proposal supersedes a proposal from 2019-10-28.

This proposal has been superseded by a proposal from 2019-10-29.

Description of the change

Fixes snap build issues from prior version.

I've verified the snap passes tests and builds, and installed it locally to verify both that the needed systemd python module code is getting installed, and that git-ubuntu.import-source-packages starts up without error.

I've updated this with additional test coverage for scripts, and various other checks that would have helped spot this and other failures during CI. [I'm anticipating this may uncover some new bugs, but am posting the CI as the most convenient way to trigger the new tests.]

Revision history for this message

Server Team CI bot (server-team-bot) wrote on 2019-10-28: Posted in a previous version of this proposal

PASSED: Continuous integration, rev:110b7073e541d3e2fd562cfb29874edbef078a27
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/381/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    SUCCESS: Unit Tests
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/381//rebuild

review: Approve (continuous-integration)

Revision history for this message

Robie Basak (racb) wrote on 2019-10-29: Posted in a previous version of this proposal

This looks good, thanks.

Is it possible to add a test for the failure this fixes please? I'm open on exactly what form this takes, but what I'd like is for something that causes CI to fail on the state of affairs before this fix.

I don't know if you'd like to do this using a test that calls importlib.import_module() or similar, or just some test file that runs "import" at the top level with a comment explaining why it is there.

review: Needs Fixing

Revision history for this message

Server Team CI bot (server-team-bot) wrote on 2019-10-29: Posted in a previous version of this proposal

FAILED: Continuous integration, rev:8a2be558d674ef918707d9a1b6ff70ea553f149b
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/384/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    FAILED: Unit Tests

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/384//rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Server Team CI bot (server-team-bot) wrote on 2019-10-29:

FAILED: Continuous integration, rev:8a2be558d674ef918707d9a1b6ff70ea553f149b
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/385/
Executed test runs:
    SUCCESS: VM Setup
    SUCCESS: Build
    FAILED: Unit Tests

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/git-ubuntu-ci/385//rebuild