Code review comment for ~bryce/+git/server-backports:update-to-lunar

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

I like the json, that will help passing this task between developers and tooling.
In a future version "notes" could be a list and that list could go into the changelog we generate.

One question on that json file though, does this need to be per-target-release?
If so, should we do that now or next time (fine with me, but add a TODO: somewhere).

---

I've left a comment for an edge case that - now that it is more paint-by-numbers - has the risk to be missed or surprise someone.
That is a minimal extra paragraph for the readme.

---

And then there is the overall scope.
We have - and sorry if that wasn't clear in the readme - the intent to:
- provide these for Ubuntu LTS releases
- update them following up to next-next-LTS

At this point the tradeoff of backport effort vs gain is diminishing.

Due to that bionic is intentionally stuck on backports from Jammy.
But Focal would continue to move until it is based on 24.04 NN.
And AFAICS so far this only includes the builds for Jammy.
So the Focal builds should be updated as well and probably the documentation aspect that made you miss it.

review: Needs Fixing

« Back to merge proposal