Bryce Harrington

Merge ~bryce/+git/oci-dev-tools:implement-build-and-status into ~bryce/+git/oci-dev-tools:master

  1. Git
  2. lp:~bryce/+git/oci-dev-tools
  3. implement-build-and-status
  4. Merge into master
Proposed by Bryce Harrington
Status: Merged
Merged at revision: 546cbde5827c65c26dc84f49059c58447be212ab
Proposed branch: ~bryce/+git/oci-dev-tools:implement-build-and-status
Merge into: ~bryce/+git/oci-dev-tools:master
Diff against target: 144 lines (+79/-8)
2 files modified
oci/lp.py (+2/-2)
scripts/oci (+77/-6)
Reviewer Review Type Date Requested Status
Athos Ribeiro (community) Approve
Canonical Server Pending
Sergio Durigan Junior Pending
Review via email: mp+401746@code.staging.launchpad.net

Description of the change

This implements basic build, show, and status commands.

This does not (yet) work against the ubuntu-docker-images project, I'm just testing against the lma project. See the commits for usage and examples.

One problem is that the LP api doesn't appear to provide collections, so it's not possible to look up, for example, 'latest builds against this recipe' or 'recipes for this image', which would help a lot in generating status info. Maybe we can get the LP folks to add those, or just screenscrape them off the web ui. But anyway this is a solid step forward regardless.

To post a comment you must log in.
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

LGTM!

Would it be worth to have the script to output a json format so we can parse the output later? For instance, parsing the upload status for a given build could help us to trigger retries in the future.

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Thanks for the review Athos, and yes I also was thinking that json (and maybe yaml?) output would be handy to work on next.

Revision history for this message
Bryce Harrington (bryce) wrote :

One consideration I'm debating for the json is that I know the object itself is transmitted from launchpad in json format already, so I need to think about if it might make sense to just dump that directly, rather than generate it myself. OTOH the launchpad object may be a bit noisy, and there may be additional information that this script can add beyond what launchpad provides. So I want to play around with it a bit before deciding.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: