Merge lp://staging/~brian.curtin/ubuntu-sso-client/correct-subprocess-args into lp://staging/ubuntu-sso-client
Proposed by
Brian Curtin
Status: | Merged |
---|---|
Approved by: | Brian Curtin |
Approved revision: | 1011 |
Merged at revision: | 1007 |
Proposed branch: | lp://staging/~brian.curtin/ubuntu-sso-client/correct-subprocess-args |
Merge into: | lp://staging/ubuntu-sso-client |
Diff against target: |
79 lines (+6/-29) 3 files modified
ubuntu_sso/utils/__init__.py (+6/-3) ubuntu_sso/utils/runner/qt.py (+0/-7) ubuntu_sso/utils/runner/tests/test_qt.py (+0/-19) |
To merge this branch: | bzr merge lp://staging/~brian.curtin/ubuntu-sso-client/correct-subprocess-args |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
dobey (community) | Approve | ||
Mike McCracken (community) | Approve | ||
Review via email: mp+129442@code.staging.launchpad.net |
Commit message
- Remove an extra insertion of "python" to command line arguments on Windows.
Description of the change
Remove an extra inserted "python" argument at the front of a command argument list.
On Windows, we were inserting "python" at the front and then passing the list off to ubuntu_
To post a comment you must log in.
On my win7 vm, many tests fail/err, but it's the same proxy related ones as on trunk.
Otherwise, works for me as long as I fix the issue with logging.conf that will be fixed by an upcoming branch, see bug #1067489