These changes look good. I just had a few questions:
* On line 28 of the diff, there are brackets around ObjectModifiedEvent. I assume that is a left-over from earlier imports?
* The docstring for TestModificationNotification should either be made more general, or the class name should be made more specific to match the docstring.
* Is the sanity check for the stub mailer on line 50 of the diff necessary? I would hope the TestCase object reliably cleans up the stub mailer for you.
I think the branch looks good. r=mars with the tweaks I listed above.
Hi Brian,
These changes look good. I just had a few questions:
* On line 28 of the diff, there are brackets around ObjectModifiedE vent. I assume that is a left-over from earlier imports? nNotification should either be made more general, or the class name should be made more specific to match the docstring.
* The docstring for TestModificatio
* Is the sanity check for the stub mailer on line 50 of the diff necessary? I would hope the TestCase object reliably cleans up the stub mailer for you.
I think the branch looks good. r=mars with the tweaks I listed above.
Maris